Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share code between cask token and formula name audits. #17562

Merged
merged 4 commits into from
Aug 10, 2024
Merged

Share code between cask token and formula name audits. #17562

merged 4 commits into from
Aug 10, 2024

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Jun 25, 2024 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This relaxes the casks token audit and makes the formula name audit more strict.

@reitermarkus reitermarkus marked this pull request as draft June 25, 2024 21:04
Rylan12
Rylan12 reviewed Jun 25, 2024
View reviewed changes
Library/Homebrew/token_auditor.rb Outdated Show resolved Hide resolved
Library/Homebrew/token_auditor.rb Outdated Show resolved Hide resolved
@MikeMcQuaid
Copy link
Member

This relaxes the casks token audit and makes the formula name audit more strict.

I think it's nicer to maintain consistency between them both, making/keeping them both stricter.

@reitermarkus reitermarkus force-pushed the token-auditor branch 2 times, most recently from 44fd8ad to e2655a3 Compare June 26, 2024 17:46
@reitermarkus
Copy link
Member Author

I think it's nicer to maintain consistency between them both, making/keeping them both stricter.

Can you clarify what you mean here?

@MikeMcQuaid
Copy link
Member

I think it's nicer to maintain consistency between them both, making/keeping them both stricter.

Can you clarify what you mean here?

I'm not sure how to clarify, really! I'm just disagreeing with the sentence here that relaxing the token audit so that it's not consistent with the formula name audit seems like introducing undesirable inconsistency.

@reitermarkus
Copy link
Member Author

reitermarkus commented Jun 26, 2024 •
edited
Loading

relaxing the token audit so that it's not consistent with the formula name audit seems like introducing undesirable inconsistency

The cask token audit is relaxed a bit while the formula name is made more strict, so the end result is they are consistent.

@MikeMcQuaid
Copy link
Member

The cask token audit is relaxed a bit while the formula name is made more strict, so the end result is they are consistent.

Hah, ok, sorry for my misunderstanding then 👍🏻

@reitermarkus reitermarkus marked this pull request as ready for review June 27, 2024 15:27
@reitermarkus reitermarkus changed the title WIP: Share code between cask token and formula name audits. Share code between cask token and formula name audits. Jun 27, 2024
MikeMcQuaid
MikeMcQuaid reviewed Jun 28, 2024
View reviewed changes
Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
Library/Homebrew/token_auditor.rb Outdated Show resolved Hide resolved
@Rylan12 Rylan12 removed their request for review June 29, 2024 01:11
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jul 21, 2024
@github-actions github-actions bot closed this Jul 28, 2024
@reitermarkus reitermarkus reopened this Jul 30, 2024
@reitermarkus
Copy link
Member Author

reitermarkus commented Jul 30, 2024 •
edited
Loading

These casks should be renamed/aliased:

  • iina-plus -> iina+
  • intel-psxe-ce-c-plus-plus -> intel-psxe-ce-c++
  • logi-options-plus -> logi-options+
  • qlc-plus -> qlc+
  • starnet-plus-plus -> starnet++
  • xournal-plus-plus -> xournal++
  • 4k-video-downloaderplus -> 4k-video-downloader+
  • easy-move-plus-resize -> easy-move+resize
  • font-mplus -> font-m+
  • font-mplus-nerd-font -> font-m+-nerd-font
  • font-rounded-mplus -> font-rounded-m+
  • tla-plus-toolbox -> tla+-toolbox

@github-actions github-actions bot removed the stale No recent activity label Jul 30, 2024
@MikeMcQuaid
Copy link
Member

Good to self-merge when you're happy @reitermarkus!

@reitermarkus reitermarkus merged commit 8e08a69 into Homebrew:master Aug 10, 2024
24 checks passed
@reitermarkus reitermarkus deleted the token-auditor branch August 10, 2024 17:46
This was referenced Aug 10, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rylan12 Rylan12 Rylan12 left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reitermarkus @MikeMcQuaid @Rylan12